feat: support both Fedora 37 and 38 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejch
commented
Jun 10, 2023
rndmh3ro
approved these changes
Jun 12, 2023
|
Looks like the docker build assumes the |
Signed-off-by: Nejc Habjan <nejc.habjan@siemens.com>
Signed-off-by: Nejc Habjan <nejc.habjan@siemens.com>
Signed-off-by: Nejc Habjan <nejc.habjan@siemens.com>
Signed-off-by: Nejc Habjan <nejc.habjan@siemens.com>
@rndmh3ro sorry, looks like even secrets defined in forks don't end up propagated to PR workflows so I added 8633f08 to make PRs from forks work out of the box. Let me know if you're happy to merge like that or I can separate that into its own PR :) |
|
That's great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dev-sec/ansible-collection-hardening#671, #21.
fde891f renames
latestto an explicit 38 version.7af061a brings back Fedora 37.
Currently a complete copy as AFAIK there are no changes needed from what I could see in the hardening repo.
This shouldn't be a breaking change as old tags of https://hub.docker.com/r/rndmh3ro/docker-fedora-ansible/tags will stay on Docker Hub.
/cc @rndmh3ro @dlouzan